Conversation
removed TODO for testChangePassword, which is functionally the same as testResetPassword.
taoTimTim
approved these changes
Mar 29, 2025
Collaborator
taoTimTim
left a comment
taoTimTim
left a comment
There was a problem hiding this comment.
Looks great, nice to have the problems dealt with to keep IDE clean.
All tests are passing.
Ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch removes all unused variables, fields, and imports, as well as all uses of the mockbean annotation, which is deprecated. This cuts the number of warnings from 43 to 2. The only warnings that remain are warnings for the github secrets environment variables, which are unable to be addressed or suppressed due to an unfixed bug with github.