Conversation
LucasSlunt
requested changes
Apr 2, 2025
Owner
LucasSlunt
left a comment
LucasSlunt
left a comment
There was a problem hiding this comment.
maxAge is based on milliseconds, but the provided value of 1800 is based on seconds. For a TTL of half an hour, use maxAge: 0.5 * 60 * 60 * 1000.
Collaborator
Author
This is wrong. It is in second as per documentation: |
taoTimTim
approved these changes
Apr 2, 2025
Collaborator
taoTimTim
left a comment
taoTimTim
left a comment
There was a problem hiding this comment.
The documentation comment runs true, it is in seconds. This is ready to be merged. Nice catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
30 min TTL on login.
Resolves #171