-
Notifications
You must be signed in to change notification settings - Fork 250
refactor(draft): codify proposal row layout #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dusterbloom
wants to merge
1
commit into
Luce-Org:main
Choose a base branch
from
dusterbloom:feat/dspark-draft-contract
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| #pragma once | ||
|
|
||
| namespace dflash::common { | ||
|
|
||
| // Draft artifacts expose one of two row layouts. Existing DFlash and DS4 | ||
| // DSpark artifacts include the accepted seed in row zero; proposal-only | ||
| // artifacts such as Bonsai rely on the runtime to prepend the accepted anchor | ||
| // before target verification. | ||
| enum class DraftProposalLayout { | ||
| SeedThenProposals, | ||
| ProposalsOnly, | ||
| }; | ||
|
|
||
| struct DraftProposalShape { | ||
| int draft_rows = 0; | ||
| DraftProposalLayout layout = DraftProposalLayout::SeedThenProposals; | ||
|
|
||
| constexpr int first_proposal_row() const noexcept { | ||
| return layout == DraftProposalLayout::ProposalsOnly ? 0 : 1; | ||
| } | ||
|
|
||
| constexpr int proposal_count() const noexcept { | ||
| const int count = draft_rows - first_proposal_row(); | ||
| return count > 0 ? count : 0; | ||
| } | ||
|
|
||
| // Verification always includes the already accepted anchor exactly once. | ||
| constexpr int verify_width() const noexcept { return 1 + proposal_count(); } | ||
| }; | ||
|
|
||
| } // namespace dflash::common |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| #include "draft/draft_contract.h" | ||
|
|
||
| using namespace dflash::common; | ||
|
|
||
| constexpr DraftProposalShape legacy{16, DraftProposalLayout::SeedThenProposals}; | ||
| static_assert(legacy.first_proposal_row() == 1); | ||
| static_assert(legacy.proposal_count() == 15); | ||
| static_assert(legacy.verify_width() == 16); | ||
|
|
||
| constexpr DraftProposalShape native{4, DraftProposalLayout::ProposalsOnly}; | ||
| static_assert(native.first_proposal_row() == 0); | ||
| static_assert(native.proposal_count() == 4); | ||
| static_assert(native.verify_width() == 5); | ||
|
|
||
| constexpr DraftProposalShape anchor_only{1, DraftProposalLayout::SeedThenProposals}; | ||
| static_assert(anchor_only.proposal_count() == 0); | ||
| static_assert(anchor_only.verify_width() == 1); | ||
|
|
||
| constexpr DraftProposalShape empty_native{0, DraftProposalLayout::ProposalsOnly}; | ||
| static_assert(empty_native.proposal_count() == 0); | ||
| static_assert(empty_native.verify_width() == 1); | ||
|
|
||
| constexpr DraftProposalShape default_shape{}; | ||
| static_assert(default_shape.layout == DraftProposalLayout::SeedThenProposals); | ||
| static_assert(default_shape.proposal_count() == 0); | ||
| static_assert(default_shape.verify_width() == 1); | ||
|
|
||
| int main() { return 0; } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intentional no consumer for this field in this PR?