Skip to content

fix(server): avoid parsing shadowed max-token aliases#549

Open
Graffioh wants to merge 1 commit into
Luce-Org:mainfrom
Graffioh:codex/fix-max-output-alias-parsing
Open

fix(server): avoid parsing shadowed max-token aliases#549
Graffioh wants to merge 1 commit into
Luce-Org:mainfrom
Graffioh:codex/fix-max-output-alias-parsing

Conversation

@Graffioh

@Graffioh Graffioh commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

(low prio fix)

  • Parse only the highest-priority max-token alias.
  • Preserve the existing alias precedence while ignoring malformed shadowed values.

Example

{
  "max_tokens": 100,
  "max_completion_tokens": "invalid"
}

Previously the unused max_completion_tokens value was eagerly parsed and rejected. The request now uses max_tokens: 100.

Testing

  • Added one focused server unit test.
  • git diff --check

@Graffioh
Graffioh marked this pull request as ready for review July 20, 2026 17:00

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

@Graffioh
Graffioh force-pushed the codex/fix-max-output-alias-parsing branch from 5ed7f44 to 01ea7e9 Compare July 20, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant