app/upgrades: add v1.11.1 audit min_disk_free_percent floor#106
Open
mateeullahmalik wants to merge 1 commit intomasterfrom
Open
app/upgrades: add v1.11.1 audit min_disk_free_percent floor#106mateeullahmalik wants to merge 1 commit intomasterfrom
mateeullahmalik wants to merge 1 commit intomasterfrom
Conversation
Reviewed all changed files. The upgrade handler correctly enforces a monotonic floor on Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1.11.1audit.params.min_disk_free_percent >= 15at upgrade executionv1.11.1into the central upgrade registry and upgrade testsContext
Mainnet needs a deterministic, upgrade-time safety floor for audit host disk-free enforcement, without mutating historical
v1.11.0semantics.Safety / Correctness
RunMigrationsfirst, then applies bounded param updateAuditKeeperwiring is missingFiles Changed
app/upgrades/upgrades.goapp/upgrades/upgrades_test.goapp/upgrades/v1_11_1/upgrade.go(new)app/upgrades/v1_11_1/upgrade_test.go(new)Tests
Executed:
go test ./app/upgrades/... ./x/audit/v1/keeper/...All passed.