fix(cascade): sn-api path handling, task polling, and total_size JSON type#7
Closed
mateeullahmalik wants to merge 1 commit intomasterfrom
Closed
fix(cascade): sn-api path handling, task polling, and total_size JSON type#7mateeullahmalik wants to merge 1 commit intomasterfrom
mateeullahmalik wants to merge 1 commit intomasterfrom
Conversation
mateeullahmalik
force-pushed
the
fix/cascade-snapi-url-status-total-size
branch
from
f8baa5d to
98c95d4
Compare
- Fix availability_commitment.total_size serialization: emit JSON number with safe bigint guard\n- Preserve baseUrl path prefixes (e.g. /proxy/snapi) when building request URLs\n- Poll task history for status instead of SSE /status endpoint, with compatibility fallback
Reviewing your PR now. I'll share feedback in a few minutes! |
Contributor
Author
|
Superseded by #6. The same fixes were moved to branch |
Reviewing your PR now. Comments will be posted shortly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes JS SDK cascade upload/download integration issues discovered in LEP-5 E2E runs against sn-api-server.
Fixes included
availability_commitment.total_sizeJSON typebigintwith guard againstNumber.MAX_SAFE_INTEGERsn-api URL path handling with base path prefixes
baseUrlcontains a prefix (e.g./proxy/snapi)/api/v1/...) from dropping the prefix and causing 404sTask status polling compatibility
Why
In browser/devnet E2E, the SDK could register the action ticket on-chain but failed to continue due to:
Validation
Validated in devnet E2E workflow:
sdk:completed) ✅