feat: Add HTTP gateway for SupernodeService with status and services …#107
Merged
mateeullahmalik merged 4 commits intomasterfrom Jul 31, 2025
Merged
feat: Add HTTP gateway for SupernodeService with status and services …#107mateeullahmalik merged 4 commits intomasterfrom
mateeullahmalik merged 4 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an HTTP gateway for the SupernodeService, introducing REST endpoints for status and services information alongside the existing gRPC service. It includes field renaming for better semantic clarity and infrastructure for HTTP-based API access.
- Adds HTTP gateway server with REST endpoints at
/api/v1/statusand/api/v1/services - Renames
ServicestoRunningTasksandAvailableServicestoRegisteredServicesfor semantic clarity - Introduces new
ListServicesendpoint to expose available gRPC service methods
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| proto/supernode/supernode.proto | Adds HTTP annotations and new ListServices RPC with field renames |
| supernode/node/supernode/gateway/ | New HTTP gateway implementation with Swagger UI support |
| supernode/config/ | Adds gateway_port configuration option |
| supernode/cmd/ | Updates initialization and startup to include gateway server |
| Multiple test files | Updates tests to use renamed fields (Services → RunningTasks) |
| Generated files | Updated protobuf and gRPC gateway generated code |
Comment on lines
+183
to
+190
| "services": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "object", | ||
| "$ref": "#/definitions/StatusResponseServiceTasks" | ||
| } | ||
| }, | ||
| "availableServices": { |
There was a problem hiding this comment.
The swagger.json file contains outdated field names. The 'services' field should be 'runningTasks' and 'availableServices' should be 'registeredServices' to match the protobuf changes.
Suggested change
| "services": { | |
| "type": "array", | |
| "items": { | |
| "type": "object", | |
| "$ref": "#/definitions/StatusResponseServiceTasks" | |
| } | |
| }, | |
| "availableServices": { | |
| "runningTasks": { | |
| "type": "array", | |
| "items": { | |
| "type": "object", | |
| "$ref": "#/definitions/StatusResponseServiceTasks" | |
| } | |
| }, | |
| "registeredServices": { |
a-ok123
previously approved these changes
Jul 31, 2025
j-rafique
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…endpoints