Merged
Conversation
Contributor
|
@akobrin1 please make |
… dynamic service/method introspection. Supports config overrides via command-line flags and environment variables. Reflection-based list command now supports both service enumeration and detailed method listing.
… dynamic service/method introspection. Supports config overrides via command-line flags and environment variables. Reflection-based list command now supports both service enumeration and detailed method listing.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new command-line client (sncli) for interacting with Lumera Supernodes over secure gRPC connections. The client provides essential functionality for health checks, service discovery, and status monitoring of Supernode instances.
Key changes include:
- New CLI application with configuration management and secure gRPC connectivity
- Updated dependency versions for the sonic JSON library
- Build system integration for the new CLI tool
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates sonic dependency versions and reformats replace directives |
| cmd/sncli/main.go | Entry point for the new CLI application |
| cmd/sncli/go.mod | Module definition and dependencies for the CLI |
| cmd/sncli/config.toml | Default configuration template |
| cmd/sncli/cli/types.go | Configuration and option structures |
| cmd/sncli/cli/sn_cmds.go | Supernode-specific command implementations |
| cmd/sncli/cli/list_grpc.go | gRPC service discovery functionality |
| cmd/sncli/cli/dispatch.go | Command routing and help system |
| cmd/sncli/cli/cli.go | Core CLI initialization and configuration handling |
| cmd/sncli/README.md | Documentation for the CLI tool |
| Makefile | Build target for the new CLI application |
Comments suppressed due to low confidence (2)
go.mod:3
- Go version 1.24.1 does not exist. The latest Go version as of my knowledge cutoff is 1.23. This should be corrected to a valid Go version.
go 1.24.1
cmd/sncli/go.mod:3
- Go version 1.24.1 does not exist. The latest Go version as of my knowledge cutoff is 1.23. This should be corrected to a valid Go version.
go 1.24.1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
a-ok123
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.