Automate Keyring Unlock — No More Pass-Phrase Prompts#110
Merged
mateeullahmalik merged 5 commits intomasterfrom Jul 31, 2025
Merged
Automate Keyring Unlock — No More Pass-Phrase Prompts#110mateeullahmalik merged 5 commits intomasterfrom
mateeullahmalik merged 5 commits intomasterfrom
Conversation
j-rafique
previously approved these changes
Jul 31, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements automated keyring unlock functionality to eliminate interactive passphrase prompts during supernode startup. It adds support for three passphrase sources (plain text, environment variable, or file) in the configuration and modifies the keyring initialization to automatically feed the passphrase to the Cosmos SDK when provided.
- Adds passphrase configuration options (
passphrase_plain,passphrase_env,passphrase_file) to KeyringConfig - Implements automated stdin replacement with a pipe for non-interactive keyring operations
- Updates keyring initialization to use the new configuration structure instead of separate parameters
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/keyring/keyring.go | Core keyring automation logic with stdin pipe replacement and passphrase handling |
| supernode/config/config.go | Adds three new passphrase fields to KeyringConfig structure |
| supernode/config/save.go | Updates CreateDefaultConfig to accept passphrase parameters |
| supernode/cmd/init.go | Adds CLI flags and interactive prompts for passphrase configuration |
| supernode/cmd/helpers.go | Updates keyring initialization to use new config structure |
| supernode/cmd/start.go | Switches to config-based keyring initialization |
| supernode/cmd/supernode.go | Removes unused accountAddress field |
| tests/system/e2e_cascade_test.go | Updates test to use new keyring initialization API |
| README.md | Documents new passphrase configuration options and CLI flags |
a-ok123
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Automate Keyring Unlock — No More Pass-Phrase Prompts
✨ Summary
This PR makes supernode start-up fully non-interactive on Cosmos-SDK v0.50.13.
When a pass-phrase is supplied in
config.yml(passphrase_plain | _env | _file) we:feed it to the SDK on an endless loop, and
swap
os.Stdinfor a pipe soinput.GetPasswordtreats the session as non-TTY.Local developers who omit the pass-phrase still get the normal prompt.
🗂️ Files Changed