Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the HTTP gateway server to bind to a specific IP address instead of listening on all interfaces. The change allows the gateway to use the supernode's configured IP address for more precise network control.
- Added IP address parameter to the gateway server configuration
- Modified server binding to use the specific IP address with the port
- Updated logging to include the bound IP address for better observability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| supernode/node/supernode/gateway/server.go | Added ipAddress field to Server struct and modified NewServer to accept IP address parameter, updated server binding logic |
| supernode/cmd/start.go | Updated gateway server initialization to pass the supernode's configured IP address |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| // NewServer creates a new HTTP gateway server that directly calls the service | ||
| func NewServer(port int, supernodeServer pb.SupernodeServiceServer) (*Server, error) { | ||
| func NewServer(ipAddress string, port int, supernodeServer pb.SupernodeServiceServer) (*Server, error) { |
There was a problem hiding this comment.
The ipAddress parameter lacks input validation. Consider validating that the provided IP address is valid using net.ParseIP() to prevent runtime errors when starting the server.
a-ok123
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.