Implement configuration verification#124
Merged
mateeullahmalik merged 4 commits intomasterfrom Aug 15, 2025
Merged
Conversation
Contributor
|
@mateeullahmalik please address co-pilot coments |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements configuration verification functionality for supernode startup, ensuring that configuration parameters match the on-chain supernode registration before services are initialized.
- Adds comprehensive configuration verification system with checks for keyring, identity, ports, and chain registration
- Integrates configuration verification into the supernode startup process with validation before service initialization
- Updates test configuration files to use localhost instead of 0.0.0.0 for better local development
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| supernode/services/verifier/interface.go | Defines the ConfigVerifierService interface and supporting types for verification results |
| supernode/services/verifier/verifier.go | Implements the configuration verification service with chain validation logic |
| supernode/services/verifier/verifier_test.go | Provides unit tests for the verification service and result structures |
| supernode/cmd/start.go | Integrates config verification into supernode startup process |
| tests/system/config.test-*.yml | Updates test configurations to use localhost instead of 0.0.0.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| result.Warnings = append(result.Warnings, ConfigError{ | ||
| Field: "host", | ||
| Expected: cv.config.SupernodeConfig.Host, | ||
| Actual: chainHost, |
There was a problem hiding this comment.
The Expected and Actual fields are swapped in the warning. Expected should be the chain value and Actual should be the config value for consistency with other checks.
Suggested change
| Actual: chainHost, | |
| Expected: chainHost, | |
| Actual: cv.config.SupernodeConfig.Host, |
j-rafique
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.