Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes task cleanup by adding proper status updates to the SuperNodeTask.RunHelper method. The change ensures that tasks are marked with appropriate completion statuses based on their execution results.
- Captures the error from RunAction before returning it
- Updates task status to StatusTaskCanceled on error or StatusTaskCompleted on success
- Maintains the original error return behavior
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
j-rafique
approved these changes
Aug 20, 2025
66923a3 to
bcd8f2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.