Skip to content

Fix task cleanup#128

Merged
mateeullahmalik merged 1 commit intomasterfrom
fix/task-cleanup
Aug 20, 2025
Merged

Fix task cleanup#128
mateeullahmalik merged 1 commit intomasterfrom
fix/task-cleanup

Conversation

@mateeullahmalik
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes task cleanup by adding proper status updates to the SuperNodeTask.RunHelper method. The change ensures that tasks are marked with appropriate completion statuses based on their execution results.

  • Captures the error from RunAction before returning it
  • Updates task status to StatusTaskCanceled on error or StatusTaskCompleted on success
  • Maintains the original error return behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mateeullahmalik mateeullahmalik merged commit c641ad2 into master Aug 20, 2025
7 checks passed
@mateeullahmalik mateeullahmalik deleted the fix/task-cleanup branch August 21, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants