Skip to content

feat: replace external IP with lumera sn address#135

Merged
mateeullahmalik merged 1 commit intomasterfrom
feat/replace-external-ip-with-chain-address
Aug 21, 2025
Merged

feat: replace external IP with lumera sn address#135
mateeullahmalik merged 1 commit intomasterfrom
feat/replace-external-ip-with-chain-address

Conversation

@mateeullahmalik
Copy link
Collaborator

No description provided.

@a-ok123 a-ok123 requested review from a-ok123 and Copilot August 21, 2025 02:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces external IP address discovery with supernode address resolution from the Lumera blockchain. The change eliminates external HTTP calls to IP discovery services and instead queries the chain to get the latest registered address for each supernode.

  • Removes external IP discovery utilities and HTTP-based address resolution
  • Adds new GetSupernodeWithLatestAddress method to retrieve processed supernode information including latest address and state
  • Updates P2P networking layer to use blockchain-registered addresses instead of external IP services

Reviewed Changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
supernode/services/verifier/verifier.go Updates config verification to use new supernode info method and removes P2P port check
supernode/services/common/supernode/service.go Simplifies status service to use blockchain address instead of external IP fallback
sdk/adapters/lumera/adapter.go Adds new SuperNodeInfo struct and GetSupernodeWithLatestAddress method implementation
sdk/action/client.go Updates client to use new supernode info method for address resolution
pkg/utils/utils.go Removes external IP discovery functions and related HTTP utilities
pkg/testutil/lumera.go Adds mock implementation for new GetSupernodeWithLatestAddress method
pkg/lumera/modules/supernode/*.go Adds interface, implementation, and mocks for new supernode info method
p2p/p2p.go Removes external IP configuration option from P2P setup
p2p/kademlia/*.go Replaces external IP discovery with blockchain-based supernode address resolution
p2p/config.go Removes ExternalIP configuration field

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mateeullahmalik mateeullahmalik merged commit 8b96063 into master Aug 21, 2025
7 checks passed
@mateeullahmalik mateeullahmalik deleted the feat/replace-external-ip-with-chain-address branch August 21, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants