feat: replace external IP with lumera sn address#135
Merged
mateeullahmalik merged 1 commit intomasterfrom Aug 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces external IP address discovery with supernode address resolution from the Lumera blockchain. The change eliminates external HTTP calls to IP discovery services and instead queries the chain to get the latest registered address for each supernode.
- Removes external IP discovery utilities and HTTP-based address resolution
- Adds new
GetSupernodeWithLatestAddressmethod to retrieve processed supernode information including latest address and state - Updates P2P networking layer to use blockchain-registered addresses instead of external IP services
Reviewed Changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| supernode/services/verifier/verifier.go | Updates config verification to use new supernode info method and removes P2P port check |
| supernode/services/common/supernode/service.go | Simplifies status service to use blockchain address instead of external IP fallback |
| sdk/adapters/lumera/adapter.go | Adds new SuperNodeInfo struct and GetSupernodeWithLatestAddress method implementation |
| sdk/action/client.go | Updates client to use new supernode info method for address resolution |
| pkg/utils/utils.go | Removes external IP discovery functions and related HTTP utilities |
| pkg/testutil/lumera.go | Adds mock implementation for new GetSupernodeWithLatestAddress method |
| pkg/lumera/modules/supernode/*.go | Adds interface, implementation, and mocks for new supernode info method |
| p2p/p2p.go | Removes external IP configuration option from P2P setup |
| p2p/kademlia/*.go | Replaces external IP discovery with blockchain-based supernode address resolution |
| p2p/config.go | Removes ExternalIP configuration field |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a-ok123
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.