p2p/kademlia: add nil guards to connWrapper and pool#176
Merged
mateeullahmalik merged 1 commit intomasterfrom Sep 18, 2025
Merged
p2p/kademlia: add nil guards to connWrapper and pool#176mateeullahmalik merged 1 commit intomasterfrom
mateeullahmalik merged 1 commit intomasterfrom
Conversation
Collaborator
mateeullahmalik
commented
Sep 17, 2025
- What: Add nil-safety to connWrapper and prevent typed-nil wrappers entering the pool.
- Changes:
- Guard Read/Write/Set Deadline against nil receiver/inner conns, return io.ErrClosedPipe.
- Make Close/LocalAddr/RemoteAddr nil-safe.
- Ignore typed-nil *connWrapper in ConnPool.Add.
- Why: Prevents "RARE" typed-nil interface cases from causing hangs or panics in Kademlia read/write paths.
- Impact: No behavior change for valid connections; safer failure mode for invalid wrappers. No public API changes.
j-rafique
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.