Conversation
Add pprof routing via swagger
Route pprof via swagger endpoints
* cleanup * supernode task tracking * deterministic supernode selection in sdk * use v1.7.2 lumera in test
…and resolve conflicts
Optimize symbol fetch
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| verificationResult, err := configVerifier.VerifyConfig(ctx) | ||
| if err != nil { | ||
| logtrace.Fatal(ctx, "Config verification failed", logtrace.Fields{"error": err.Error()}) | ||
| } | ||
|
|
||
| if !verificationResult.IsValid() { | ||
| logtrace.Fatal(ctx, "Config verification failed", logtrace.Fields{"summary": verificationResult.Summary()}) | ||
| if err != nil || (verificationResult != nil && !verificationResult.IsValid()) { | ||
| logFields := logtrace.Fields{"error": err.Error()} | ||
| if verificationResult != nil { |
There was a problem hiding this comment.
The new combined check dereferences err unconditionally via logtrace.Fields{"error": err.Error()}. When VerifyConfig returns an invalid result with err == nil (e.g. configuration is syntactically valid but mismatched with chain registration), this branch executes and panics on the nil pointer before the fatal log is emitted. The start command will crash instead of terminating gracefully on misconfiguration.
Useful? React with 👍 / 👎.
3 participants
No description provided.