Closed
Conversation
Contributor
j-rafique
commented
Nov 7, 2025
j-rafique
commented
- Use centralized RoundBytesToKB64() in sdk/action/client.go for fee calculation
- Add supernode/cascade/helper.go with proper action.Price parsing (string to sdk.Coin)
- Add comprehensive integration tests in supernode/cascade/helper_test.go
- Update go.mod to use local lumera with replace directive and Go 1.25.1
- All cascade edge cases tested (0B, 1B, 1024B, 1025B)
j-rafique
force-pushed
the
feat/centralize-fee-calculation
branch
from
965f324 to
d1b96fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.