Add ADR-36 Signature Support and Dual-Mode Index Verification for JS SDK Compatibility#231
Merged
mateeullahmalik merged 1 commit intomasterfrom Nov 16, 2025
Merged
Conversation
…SDK Compatibility
2968056 to
d457dd5
Compare
j-rafique
approved these changes
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR introduces full ADR-36 signature compatibility and JS SDK alignment for Cascade uploads, while preserving backward compatibility with all existing Go-based clients and legacy signatures.
Why
The JS SDK signs Cascade metadata (layout + index) using ADR-36 envelopes, while the existing Supernode verification logic expected raw secp256k1 signatures over base64-encoded payloads.
This mismatch caused Supernode to reject uploads initiated from the JS SDK with:
The issue affected:
What’s Changed
✅ 1. Add ADR-36 verification support in index signature validation
VerifyIndex()now attempts two verification modes:Legacy mode
indexB64JS-SDK mode
base64(indexJSON))This makes the verification layer fully backward compatible while enabling JS SDK signatures.
✅ 2. Introduce unified ADR-36 verification path
All verification paths now go through
VerifyStringRawOrADR36, allowing:This standardizes verification across:
✅ 3. No breaking changes
🔧 Highlights
Result
With these changes:
Testing