Conversation
I've reviewed the changes updating Lumera to v1.8.5 and upgrading the setup-go action. I found a minor inconsistency in error handling.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote-v0[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| }) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get action: %w", err) | ||
| return nil, err |
There was a problem hiding this comment.
This change creates an inconsistency with GetActionFee and GetParams below, which both wrap errors with context. Unless there's a specific need to return the raw error here (e.g., for specific gRPC status checking that wrapping interferes with), it's better to be consistent.
| return nil, err | |
| return nil, fmt.Errorf("failed to get action: %w", err) |
Fix it with Roo Code or mention @roomote and request a fix.
There was a problem hiding this comment.
wrapping an error in GetAction creates duplicate error... it is wrapped on higher levels in all calls to GetAction.
We need either keep wrapping in GetAction and remove wrapping with the same error message in all calls to GetAction.
| github.com/LumeraProtocol/lumera v1.8.4 | ||
| github.com/LumeraProtocol/supernode/v2 v2.3.88 | ||
| github.com/LumeraProtocol/lumera v1.8.5 | ||
| github.com/LumeraProtocol/supernode/v2 v2.0.0-00010101000000-000000000000 |
There was a problem hiding this comment.
Use 2.4.9 or code from latest directory like it is right now would be best
2 participants
No description provided.