Skip to content

fix: re-enable legacy metrics reporter for audit bootstrap #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateeullahmalik merged 1 commit into from
Mar 10, 2026
Merged

fix: re-enable legacy metrics reporter for audit bootstrap #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions supernode/cmd/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ import (
hostReporterService "github.com/LumeraProtocol/supernode/v2/supernode/host_reporter"
statusService "github.com/LumeraProtocol/supernode/v2/supernode/status"
storageChallengeService "github.com/LumeraProtocol/supernode/v2/supernode/storage_challenge"
// Legacy supernode metrics reporter (MsgReportSupernodeMetrics) has been superseded by
// epoch-scoped audit reporting in `x/audit`.
// supernodeMetrics "github.com/LumeraProtocol/supernode/v2/supernode/supernode_metrics"
supernodeMetrics "github.com/LumeraProtocol/supernode/v2/supernode/supernode_metrics"
"github.com/LumeraProtocol/supernode/v2/supernode/transport/gateway"
cascadeRPC "github.com/LumeraProtocol/supernode/v2/supernode/transport/grpc/cascade"
server "github.com/LumeraProtocol/supernode/v2/supernode/transport/grpc/status"
Expand Down Expand Up @@ -173,18 +171,22 @@ The supernode will connect to the Lumera network and begin participating in the
logtrace.Fatal(ctx, "Failed to initialize host reporter", logtrace.Fields{"error": err.Error()})
}

// Legacy on-chain supernode metrics reporting has been superseded by `x/audit`.
// metricsCollector := supernodeMetrics.NewCollector(
// statusSvc,
// lumeraClient,
// appConfig.SupernodeConfig.Identity,
// Version,
// kr,
// appConfig.SupernodeConfig.Port,
// appConfig.P2PConfig.Port,
// appConfig.SupernodeConfig.GatewayPort,
// )
// logtrace.Info(ctx, "Metrics collection enabled", logtrace.Fields{})
// Legacy on-chain supernode metrics reporting (MsgReportSupernodeMetrics)
// runs alongside the audit epoch reporter. It is needed to recover
// POSTPONED supernodes via the supernode module's instant-recovery
// path so they appear ACTIVE in the next epoch anchor — which
// bootstraps the audit peer-observation cycle.
metricsCollector := supernodeMetrics.NewCollector(
statusSvc,
lumeraClient,
appConfig.SupernodeConfig.Identity,
Version,
kr,
appConfig.SupernodeConfig.Port,
appConfig.P2PConfig.Port,
appConfig.SupernodeConfig.GatewayPort,
)
logtrace.Info(ctx, "Legacy metrics collection enabled (audit bootstrap)", logtrace.Fields{})

// Storage challenge history DB (shared by the gRPC handler and runner).
historyStore, err := queries.OpenHistoryDB()
Expand Down Expand Up @@ -253,7 +255,7 @@ The supernode will connect to the Lumera network and begin participating in the
// Start the services using the standard runner and capture exit
servicesErr := make(chan error, 1)
go func() {
services := []service{grpcServer, cService, p2pService, gatewayServer, hostReporter}
services := []service{grpcServer, cService, p2pService, gatewayServer, hostReporter, metricsCollector}
if storageChallengeRunner != nil {
services = append(services, storageChallengeRunner)
}
Expand Down