fix(cascade): persist metadata-only first batch when no symbols selected#277
Open
fix(cascade): persist metadata-only first batch when no symbols selected#277
Conversation
Reviewing your PR now. Feedback will be posted soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a first-batch persistence gap in cascade artefact storage.
Previously, storeCascadeSymbolsAndData only sent metadata (IDFiles) inside the symbol batching loop.
If no symbols were selected
(len(keys) == 0), the loop never ran, butUpdateIsFirstBatchStoredwas still called.That could mark the action as first-batch stored without actually persisting index/layout metadata to P2P.
What changed
Tests added
In supernode/adaptors/p2p_test.go:
TestStoreCascadeSymbolsAndData_MetadataOnlyBatchWhenNoSymbols
TestStoreCascadeSymbolsAndData_MetadataOnlyBatchFailureSkipsFirstBatchFlag
Why this matters
Ensures first-batch completion semantics remain correct and durable by guaranteeing metadata is persisted even when symbol selection yields zero symbols.