test(gateway): add recovery admin auth/method/throttle coverage#278
Open
j-rafique wants to merge 1 commit intocascade-store-symbols-improvementfrom
Open
test(gateway): add recovery admin auth/method/throttle coverage#278j-rafique wants to merge 1 commit intocascade-store-symbols-improvementfrom
j-rafique wants to merge 1 commit intocascade-store-symbols-improvementfrom
Conversation
No issues found. The tests correctly cover auth token validation, HTTP method enforcement, semaphore throttling, and missing-dependency error responses. Stubs properly implement their interfaces and test logic matches the production code paths. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds targeted unit tests for the new recovery admin gateway endpoints in supernode/transport/gateway/recovery_admin.go.
Given the API introduces auth gating, method-specific handlers, and semaphore-based concurrency control, this adds the minimum high-leverage coverage to reduce regression risk.
What’s covered
Why
New admin recovery surface area is operationally sensitive.
These tests lock down critical behavior around auth, request method constraints, and concurrency throttling.
Prevents accidental behavior drift in future refactors.
Validation
Ran locally:
go test ./supernode/transport/gateway
Result: ok