Skip to content

change hashing algorithm form sha256 to blake3#32

Merged
j-rafique merged 1 commit intomasterfrom
changeHashingAlgo
Apr 30, 2025
Merged

change hashing algorithm form sha256 to blake3#32
j-rafique merged 1 commit intomasterfrom
changeHashingAlgo

Conversation

@j-rafique
Copy link
Contributor

No description provided.

@j-rafique j-rafique self-assigned this Apr 29, 2025
@j-rafique j-rafique requested a review from a-ok123 April 29, 2025 15:33
a-ok123
a-ok123 previously approved these changes Apr 29, 2025
@a-ok123 a-ok123 requested a review from Copilot April 29, 2025 17:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the hashing algorithm used across various modules from SHA256 (and SHA3-256) to Blake3. Key changes include replacing calls to utils.Sha3256hash with utils.Blake3Hash in production code, updating corresponding documentation comments and error messages, and modifying tests to verify outputs of the new hash function.

Reviewed Changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/utils/storagechallenge/storage_challenge.go Updated hash function call for SCSummaryStats
pkg/utils/metrics/metrics.go Updated hash function call for Metrics
pkg/utils/healthcheckchallenge/health_check_challenge.go Updated hash function call for HCSummaryStats
pkg/types/storage_challenge.go Updated hash function calls in StorageChallengeMessages and AggregatedScoreList
pkg/types/self_healing.go Updated hash function call for SelfHealingReports
pkg/types/healthcheck_challenge.go Updated hash function call for HealthCheckChallengeMessages
pkg/raptorq/helper.go Updated hash function call; error message unchanged
pkg/net/credentials/alts/common/utils.go Adjusted import ordering and condition style
pkg/crypto/hash.go New minimal file
p2p/p2p.go Updated documentation comments to reference Blake3 correctly
p2p/kademlia/store/sqlite/* (sqlite.go, sqlite_test.go, replication.go) Updated hash function calls and documentation in store operations
p2p/kademlia/node.go Updated hashed ID computation
p2p/kademlia/network.go Updated hash function calls in network operations
p2p/kademlia/fetch_and_store.go Updated hash function call in batch operations
p2p/kademlia/dht.go Updated hash function calls and error handling
p2p/client.go Updated documentation comments for key-related methods
p2p/DEVDOCS.md Updated documentation to reflect Blake3 as the new hash algorithm
Files not reviewed (1)
  • go.mod: Language not supported

@j-rafique j-rafique merged commit 3ae7467 into master Apr 30, 2025
@j-rafique j-rafique deleted the changeHashingAlgo branch May 4, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants