Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on fixes and improvements for secure gRPC tests and related components. Key changes include:
- Splitting the keyring usage into client and server variants in tests
- Updating account setup functions to return richer test account data
- Removing duplicate comments and improving error handling/synchronization in tests
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/securegrpc/secure_connection_test.go | Split keyring creation into client/server variants for improved test isolation |
| tests/integration/p2p/p2p_integration_test.go | Refactored account setup and address extraction in p2p integration tests |
| pkg/testutil/lumera.go | Fixed address string construction by using strconv.Itoa |
| pkg/testutil/accounts.go | Changed SetupTestAccounts to return TestAccount structs and adjusted mnemonic entropy bits |
| pkg/net/grpc/server/server_test.go | Added synchronization to ensure the server goroutine completes before test termination |
| pkg/net/credentials/alts/handshake/handshake_test.go | Separated client and server keyrings and updated key exchange setup |
| pkg/net/credentials/alts/handshake/handshake.go | Removed a debug print statement from the handshake error handling logic |
| p2p/kademlia/dht.go & p2p/kademlia/bootstrap.go | Removed duplicate comments |
Files not reviewed (1)
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
pkg/net/credentials/alts/handshake/handshake_test.go:306
- Using 'for i := range tc.numHandshakes' is incorrect since tc.numHandshakes is an integer. Change it back to the traditional loop format (e.g. 'for i := 0; i < tc.numHandshakes; i++ {') to iterate the correct number of times.
for i := range tc.numHandshakes {
a-ok123
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secure Grpc Test Fixes