Skip to content

Secure Grpc Test Fixes#33

Merged
akobrin1 merged 1 commit intomasterfrom
lumeraGRPC
Apr 29, 2025
Merged

Secure Grpc Test Fixes#33
akobrin1 merged 1 commit intomasterfrom
lumeraGRPC

Conversation

@akobrin1
Copy link
Contributor

Secure Grpc Test Fixes

@a-ok123 a-ok123 requested a review from Copilot April 29, 2025 17:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR focuses on fixes and improvements for secure gRPC tests and related components. Key changes include:

  • Splitting the keyring usage into client and server variants in tests
  • Updating account setup functions to return richer test account data
  • Removing duplicate comments and improving error handling/synchronization in tests

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/integration/securegrpc/secure_connection_test.go Split keyring creation into client/server variants for improved test isolation
tests/integration/p2p/p2p_integration_test.go Refactored account setup and address extraction in p2p integration tests
pkg/testutil/lumera.go Fixed address string construction by using strconv.Itoa
pkg/testutil/accounts.go Changed SetupTestAccounts to return TestAccount structs and adjusted mnemonic entropy bits
pkg/net/grpc/server/server_test.go Added synchronization to ensure the server goroutine completes before test termination
pkg/net/credentials/alts/handshake/handshake_test.go Separated client and server keyrings and updated key exchange setup
pkg/net/credentials/alts/handshake/handshake.go Removed a debug print statement from the handshake error handling logic
p2p/kademlia/dht.go & p2p/kademlia/bootstrap.go Removed duplicate comments
Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (1)

pkg/net/credentials/alts/handshake/handshake_test.go:306

  • Using 'for i := range tc.numHandshakes' is incorrect since tc.numHandshakes is an integer. Change it back to the traditional loop format (e.g. 'for i := 0; i < tc.numHandshakes; i++ {') to iterate the correct number of times.
for i := range tc.numHandshakes {

@a-ok123 a-ok123 self-requested a review April 29, 2025 17:12
@akobrin1 akobrin1 merged commit c937bcb into master Apr 29, 2025
@akobrin1 akobrin1 deleted the lumeraGRPC branch April 29, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants