Use lumera release build with latest tag for system tests#72
Use lumera release build with latest tag for system tests#72
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Lumera installation script to support fetching the latest tag or a specific version and consolidates Go and dependency setup across workflows into a single composite action while bumping checkout actions to v4.
- Extend
install-lumera.shwithlatest-tag,latest-release(default), and specific version modes. - Update test workflows to call the script with
latest-tagand upgradeactions/checkoutto v4. - Centralize Go version parsing and system dependency installation in
.github/actions/setup-env.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/scripts/install-lumera.sh | Add MODE argument handling, fetch tags, and construct download URL |
| .github/workflows/tests.yml | Bump actions/checkout to v4 and pass latest-tag to install script |
| .github/workflows/build&release.yml | Replace per-job Go/deps setup with composite setup-env action |
| .github/actions/setup-env/action.yml | Dynamically parse Go version from go.mod and install dependencies |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the system tests deployment to use the Lumera release build with the latest tag instead of the latest release, while also streamlining the Go environment setup in the CI workflows.
- Updated the install script (install-lumera.sh) to support additional modes ("latest-tag" and specific version).
- Upgraded GitHub Actions checkout from v3 to v4 and consolidated Go setup into the custom setup-env action.
- Simplified the build&release workflow by removing redundant Go version extraction and dependency installation steps.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/scripts/install-lumera.sh | Added support for different modes (latest-tag, latest-release, specific version) for fetching Lumera builds. |
| .github/workflows/tests.yml | Upgraded checkout action and updated the call to install-lumera.sh with "latest-tag". |
| .github/workflows/build&release.yml | Consolidated Go setup into setup-env step and removed manual dependency installation. |
| .github/actions/setup-env/action.yml | Updated the composite action to dynamically extract and use the Go version from go.mod. |
Comments suppressed due to low confidence (1)
.github/actions/setup-env/action.yml:23
- Verify that the dynamic Go version extraction from go.mod is consistent with all intended use cases; consider adding error handling if no valid version is found in go.mod.
go-version: ${{ steps.get-go-version.outputs.version }}
| else | ||
| TAG_NAME=$(echo "$RELEASE_INFO" | grep -o '"tag_name"[[:space:]]*:[[:space:]]*"[^"]*"' | sed 's/.*"tag_name"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/') | ||
| DOWNLOAD_URL=$(echo "$RELEASE_INFO" | grep -o '"browser_download_url"[[:space:]]*:[[:space:]]*"[^"]*linux_amd64\.tar\.gz[^"]*"' | sed 's/.*"browser_download_url"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/') | ||
| echo "❌ Error: Invalid mode '$MODE'" |
There was a problem hiding this comment.
[nitpick] Consider adding an inline comment above this branch to list the valid mode options ('latest-release', 'latest-tag', and specific version) for clarity and easier future maintenance.
No description provided.