Merged
Conversation
af6541f to
9256f35
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the ability to specify static bootstrap nodes and external IP overrides in the P2P configuration, cleaning up related structs, defaults, and examples/tests.
- Dropped
BootstrapNodesandExternalIPfields fromP2PConfigand default config creation - Updated command entrypoints to hard-code empty values instead of reading removed fields
- Cleaned up YAML examples and test configs by removing those keys (and also removed
timeoutentries in test configs)
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/system/config.test-1.yml | Removed bootstrap_nodes, external_ip, and timeout |
| tests/system/config.test-2.yml | Removed bootstrap_nodes, external_ip, and timeout |
| tests/system/config.test-3.yml | Removed bootstrap_nodes, external_ip, and timeout |
| supernode/config/save.go | Deleted default BootstrapNodes and ExternalIP |
| supernode/config/config.go | Removed struct fields BootstrapNodes and ExternalIP |
| supernode/config.yml | Cleared out P2P keys and adjusted comments |
| supernode/cmd/supernode.go | Replaced config references with "" |
| supernode/cmd/start.go | Replaced config references with "" |
| README.md | Removed docs for dropped P2P keys |
Comments suppressed due to low confidence (3)
tests/system/config.test-3.yml:24
- The
timeoutsetting was removed from the test config butLumeraClientConfigmay not provide a default when it's missing. Consider adding a default timeout inCreateDefaultConfigor handling an omitted timeout in the config loader to prevent test failures.
chain_id: "testing"
README.md:59
- [nitpick] The
p2psection now omitsbootstrap_nodes; it would be helpful to document the new peer discovery mechanism (e.g., auto-discovery via DHT) so users understand how nodes find each other.
data_dir: "data/p2p"
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
a-ok123
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.