Skip to content

Remove bootstrap nodes#99

Merged
mateeullahmalik merged 2 commits intomasterfrom
remove-bootstrap-nodes
Jul 14, 2025
Merged

Remove bootstrap nodes#99
mateeullahmalik merged 2 commits intomasterfrom
remove-bootstrap-nodes

Conversation

@mateeullahmalik
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the ability to specify static bootstrap nodes and external IP overrides in the P2P configuration, cleaning up related structs, defaults, and examples/tests.

  • Dropped BootstrapNodes and ExternalIP fields from P2PConfig and default config creation
  • Updated command entrypoints to hard-code empty values instead of reading removed fields
  • Cleaned up YAML examples and test configs by removing those keys (and also removed timeout entries in test configs)

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/system/config.test-1.yml Removed bootstrap_nodes, external_ip, and timeout
tests/system/config.test-2.yml Removed bootstrap_nodes, external_ip, and timeout
tests/system/config.test-3.yml Removed bootstrap_nodes, external_ip, and timeout
supernode/config/save.go Deleted default BootstrapNodes and ExternalIP
supernode/config/config.go Removed struct fields BootstrapNodes and ExternalIP
supernode/config.yml Cleared out P2P keys and adjusted comments
supernode/cmd/supernode.go Replaced config references with ""
supernode/cmd/start.go Replaced config references with ""
README.md Removed docs for dropped P2P keys
Comments suppressed due to low confidence (3)

tests/system/config.test-3.yml:24

  • The timeout setting was removed from the test config but LumeraClientConfig may not provide a default when it's missing. Consider adding a default timeout in CreateDefaultConfig or handling an omitted timeout in the config loader to prevent test failures.
  chain_id: "testing"

README.md:59

  • [nitpick] The p2p section now omits bootstrap_nodes; it would be helpful to document the new peer discovery mechanism (e.g., auto-discovery via DHT) so users understand how nodes find each other.
  data_dir: "data/p2p"

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mateeullahmalik mateeullahmalik merged commit 19ed69f into master Jul 14, 2025
7 of 14 checks passed
@mateeullahmalik mateeullahmalik deleted the remove-bootstrap-nodes branch July 15, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants