Bump idna and pymdown-extensions for advisories#124
Merged
Conversation
Both flagged by Dependabot on main, both transitive, both medium-severity. Bumping via ``uv lock --upgrade-package`` so parent-package constraints stay respected and no direct pin gets added to pyproject.toml. - ``idna`` 3.13 -> 3.18 (advisory: specially-crafted inputs to ``idna.encode()`` can bypass the CVE-2024-3651 fix; first patched in 3.15). Pulled in transitively via httpx + anyio — runtime path for LLM provider HTTP calls. - ``pymdown-extensions`` 10.21.2 -> 10.21.3 (advisory: regression in ``pymdownx.snippets`` reintroduces sibling-prefix path traversal bypass despite ``restrict_base_path``; first patched in 10.21.3). Pulled in via mkdocs-material + mkdocstrings — dev-only (docs build). Lower risk in practice since we don't configure ``pymdownx.snippets``, but worth taking for hygiene. Verified: - ``uv sync`` resolves cleanly - 531/531 unit tests pass - 13/13 examples smoke tests pass - ``mkdocs build --strict`` clean - ruff + pyright clean
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the two Dependabot vulnerability alerts on main. Both transitive, both medium-severity, both fixable by a single
uv lock --upgrade-packageinvocation that respects parent-package constraints.idnaidna.encode()can bypass the CVE-2024-3651 fix (first patched 3.15)pymdown-extensionspymdownx.snippetsreintroduces sibling-prefix path traversal bypass despiterestrict_base_path(first patched 10.21.3)Lower risk on the pymdown-extensions one in practice since this project doesn't configure
pymdownx.snippets, but taking it for hygiene.No code changes needed — both are transitive, no direct pin gets added.
Test plan
uv syncresolves cleanlyuv run pytest tests/unit/— 531 passuv run pytest tests/test_examples_smoke.py— 13 passuv run mkdocs build --strict— cleanuv run ruff check+pyright— clean