[Internal review] Script for issue 2451#194
Open
GetmanetsIrina wants to merge 2 commits intodevelopfrom
Open
Conversation
VjKlepikov
approved these changes
Jun 20, 2022
|
|
||
| --[[ Local Variables ]] | ||
| local maxValue = "0x01,0x02,0x03,0x04,0x05,0x06,0x07,0x08,0x09,0x11,0x12,0x13,0x14,0x15,0x16,0x17,0x18,0x19,0x21," .. | ||
| "0x22,0x23,0x24,0x25,0x26,0x27,0x28,0x29,0x31,0x32,0x33,0x34,0x35,0x36,0x37,0x38,0x39,0x41,0x42,0x43,0x44,0x45,0x46," .. |
There was a problem hiding this comment.
Please add indents
Suggested change
| "0x22,0x23,0x24,0x25,0x26,0x27,0x28,0x29,0x31,0x32,0x33,0x34,0x35,0x36,0x37,0x38,0x39,0x41,0x42,0x43,0x44,0x45,0x46," .. | |
| "0x22,0x23,0x24,0x25,0x26,0x27,0x28,0x29,0x31,0x32,0x33,0x34,0x35,0x36,0x37,0x38,0x39,0x41,0x42,0x43,0x44,0x45,0x46," .. |
| --------------------------------------------------------------------------------------------------- | ||
| -- Issue: https://github.com/smartdevicelink/sdl_core/issues/2451 | ||
| --------------------------------------------------------------------------------------------------- | ||
| --------------------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
Suggested change
| --------------------------------------------------------------------------------------------------- |
Comment on lines
+26
to
+28
| "0x98,0x99,0x10,0x20,0x30,0x40,0x50,0x60,0x70,0x80,0x90,0x9A" | ||
| local tcs = { |
There was a problem hiding this comment.
Suggested change
| "0x98,0x99,0x10,0x20,0x30,0x40,0x50,0x60,0x70,0x80,0x90,0x9A" | |
| local tcs = { | |
| "0x98,0x99,0x10,0x20,0x30,0x40,0x50,0x60,0x70,0x80,0x90,0x9A" | |
| local tcs = { |
| -- 3. Mobile app requests RAI | ||
| -- SDL does: | ||
| -- - not send supportedDiagModes parameter in RAI response in case value is out of min size | ||
| -- - send supportedDiagModes value with cutted off elememts number to allowed size in RAI response |
There was a problem hiding this comment.
Suggested change
| -- - send supportedDiagModes value with cutted off elememts number to allowed size in RAI response | |
| -- - send supportedDiagModes value with cutted off elements number to allowed size in RAI response |
Author
|
@VjKlepikov, please find update in 976a614 |
GetmanetsIrina
force-pushed
the
defects/2451
branch
from
976a614 to
89c760e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATF Test Scripts to check #FORDTCN-5999
This PR is ready for review.
Summary
Scripts to check 2451 issue
ATF version
latest
Changelog
Note
Both scripts are failed:
CLA