Feature/sdl 0293 enable oem exclusive apps support#172
Closed
LitvinenkoIra wants to merge 15 commits intodevelopfrom
Closed
Feature/sdl 0293 enable oem exclusive apps support#172LitvinenkoIra wants to merge 15 commits intodevelopfrom
LitvinenkoIra wants to merge 15 commits intodevelopfrom
Conversation
Also added some unit tests to cover happy path Additionally, implemented new waiter-function for blocking threads until HMI readiness and release them once all data became available.
This is required to avoid timing issue as after calling `UpdateRequestsRequiredForCapabilities` another thread may be notified that everything is ready to run. Notified thread may try to access hmi capabilities values which is not set yet. That's why it is important to set capabilities values first.
There was noticed that SDL does not terminate HMI request commands in case if HMI sends response in the error format. This was fixed.
…_changes Add vehicle data params to StartSessionAck
…93_enable_oem_exclusive_apps_support
LitvinenkoIra
requested review from
AKalinich-Luxoft,
VladSemenyuk and
ychernysheva
AKalinich-Luxoft
approved these changes
Jan 13, 2021
Also delete disabled unit tests, which use outdated hard-coded values and doesn't map to current state and sections of preloaded pt. Instead new unit tests are added to check Save() and GenerateSnapshot() methods. These tests work with current version of preloaded pt, copied from AppMain folder.
Delete unused and outdated hard-coded PTs from PTRepresentation classes. Move and update affected UTs with actual version of preloaded PT, copied from AppMain folder
Author
|
Moved to smartDeviceLink |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0293-vehicle-type-filter.md
Just for review. This PR will be redirected to the smartDeviceLink organization after the revision will be accepted
This PR is ready for review.
Testing Plan
ATF test scripts from LuxoftSDL/sdl_atf_test_scripts#100
HMI from LuxoftSDL/sdl_hmi#62
Summary
CLA
rpc_spec from LuxoftSDL/rpc_spec#14