Feature/swift and keystone#1
Open
Lykos153 wants to merge 14 commits into
Open
Conversation
For the specification see: <https://github.com/rook/rook/blob/master/design/ceph/object/swift-and-keystone-integration.md> Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com> Signed-off-by: Silvio Ankermann <silvio.ankermann@cloudandheat.com>
* The parameter lists of the API call have changes, as parameters ignored by the RGW Admin Ops API are no longer serialized, therefore the mock has to be adapted. * There is now validation for the user keys that are passed to the User get API, therefore things failed when we had empty keys in our User proxy object. Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com> Signed-off-by: Silvio Ankermann <silvio.ankermann@cloudandheat.com>
For the specification see: <https://github.com/rook/rook/blob/master/design/ceph/object/swift-and-keystone-integration.md> Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com> Signed-off-by: Silvio Ankermann <silvio.ankermann@cloudandheat.com>
For the specification of the swift and keystone integration see: <https://github.com/rook/rook/blob/master/design/ceph/object/swift-and-keystone-integration.md> Signed-off-by: Sebastian Riese <sebastian.riese@cloudandheat.com> Signed-off-by: Silvio Ankermann <silvio.ankermann@cloudandheat.com>
* roll-out with swift enabled in e2e tests works, but the swift/keystone features are not yet actually tested (this requires also spinning up a keystone/keystone mock to test the integration).
If a config object (e.g. secret) is missing, only the line > ceph-object-controller: skipping reconcile since operator is still initializing is logged. This commit adds the actual error message to the log
No error messages are returned in case of an error. This commit adds an error message on each possible error.
secret.StringData is a write only construct This commit takes a different approach to reading the secrets data. Signed-off-by: Jan Klippel <jan.klippel@uhurutec.com>
The config option rgw_keystone_revocation_interval no longer exists. See - https://docs.ceph.com/en/mimic/radosgw/config-ref/ - https://docs.ceph.com/en/latest/radosgw/config-ref/ Setting it currenlty leads to an incomplete config as not every config option is set afterwards. Remove old config option. Signed-off-by: Jan Klippel <jan.klippel@uhurutec.com>
Failing option sets are not seen in the log. This commit adds a debug message to the log including the error message of the failed set. Additionally it adds a TODO in the code to review the error handling at setting the configuration options. Signed-off-by: Jan Klippel <jan.klippel@uhurutec.com>
Currently the api version is not provided in which case ceph/rgw falls back to v2. Set the rgw_keystone_adi_version explicitly to 3 Signed-off-by: Jan Klippel <jan.klippel@uhurutec.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only for integration tests