Change Request Constant into Some Random Numbers#47
Open
martabacc wants to merge 2 commits intoLynxITDigital:masterfrom
Open
Change Request Constant into Some Random Numbers#47martabacc wants to merge 2 commits intoLynxITDigital:masterfrom
martabacc wants to merge 2 commits intoLynxITDigital:masterfrom
Conversation
martabacc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When we also installs another library that uses the same constant (in my project we use
react-native-bluetooth-escpos-printer), the listener is also invoked but it throws error which resulted in force close.Note: Used constant on the library is 1 (for contact) and 2 (for email).
Steps to Reproduce
react-native-contacts-wrapperand another library that uses same constantFix
Change request constants into random numbers so hopefully it doesn't have the same constant with another library.
Edit: I also tidy the readme.