Skip to content

Homework#3_102502520#31

Open
jim83531 wants to merge 2 commits intoMAP-NCU2015:masterfrom
jim83531:homework
Open

Homework#3_102502520#31
jim83531 wants to merge 2 commits intoMAP-NCU2015:masterfrom
jim83531:homework

Conversation

@jim83531
Copy link

review?=@snowmantw
review?=@chungya
review?=@FlowerHop

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of binding an anonymous function, you should pass this as the listener of the API.

@snowmantw
Copy link
Contributor

I strongly suggest that you need to correct your homework carefully, or you may get only few points from this version. I ask you to:

  1. Correct what I've commented according to the slides I've taught
  2. If there are some issues you don't understand, or it is vague or absent, ask me. I don't mind you ask me 100 times with your questions unless you apparently don't listen to what I've answered you. Nevertheless, it's even worse to just do your homework as this
  3. Run the test manually to make sure everything is fine: there are some errors you can pick up if you have run it
  4. After you complete it, set review again

By the way, I don't know why you need to re-patch all files with your indentations, although I guess it is because of IDE issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants