Open
Conversation
Contributor
There was a problem hiding this comment.
I prefer to use addEventListener('note-open', this) instead of binding on a function, since in this way all events could be redirected to this.handleEvent, and the this keyword in that method will refer to the instance you want to bind.
See this:
https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#Example
Contributor
|
Overall you need to understand the details of Promise and event handler API more, and consider how to improve your expressiveness. For a homework to gain enough scores of course is the first priority, but you will probably get int trouble when you have a coding job. And that's basically what I try to teach all of you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
review?=@snowmantw
review?=@chungya
review?=@FlowerHop
Tier1 is finished.
I'm sorry about finishing this homework so late.