Skip to content

101403014 HW #55

Open
gmkevin00 wants to merge 1 commit intoMAP-NCU2015:homeworkfrom
gmkevin00:homework
Open

101403014 HW #55
gmkevin00 wants to merge 1 commit intoMAP-NCU2015:homeworkfrom
gmkevin00:homework

Conversation

@gmkevin00
Copy link

review?=@snowmantw
review?=@chungya
review?=@FlowerHop

Tier1 is finished.
I'm sorry about finishing this homework so late.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use addEventListener('note-open', this) instead of binding on a function, since in this way all events could be redirected to this.handleEvent, and the this keyword in that method will refer to the instance you want to bind.

See this:
https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#Example

@snowmantw
Copy link
Contributor

Overall you need to understand the details of Promise and event handler API more, and consider how to improve your expressiveness. For a homework to gain enough scores of course is the first priority, but you will probably get int trouble when you have a coding job. And that's basically what I try to teach all of you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants