Merged
Conversation
Contributor
Author
|
Do note that actions do succeed with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Directly pulls from the 4JLibs repository on checkout as a submodule to allow for automated 4JLibs builds
Changes
Previous Behavior
Precompiled libraries were used in Minecraft.Client/Windows64/lib
Root Cause
The cmake design expected libraries to be then linked, similarly to how the original source did it
New Behavior
Automatically builds and links 4JLibs independent of the platform, no extra files needed on the source tree
AI Use Disclosure
No AI was used