Code review exercise: Tay Duncan#118
Open
TashanDuncan wants to merge 31 commits intoMCR-Digital:masterfrom
Open
Code review exercise: Tay Duncan#118TashanDuncan wants to merge 31 commits intoMCR-Digital:masterfrom
TashanDuncan wants to merge 31 commits intoMCR-Digital:masterfrom
Conversation
Introduce a missing intentional difference
This commit refactors the add() method in the Game class by separating the logic into two separate functions: initializePlayer() and logNewPlayer(). This improves code readability and maintainability.
shugewang
reviewed
Jan 9, 2024
| const MAX_PLAYERS = 6 | ||
| const winningGoldCoins = 6 | ||
| var players = [] | ||
| var board = new Array(MAX_PLAYERS) |
There was a problem hiding this comment.
Could potentially extract Board into its own class?
| @@ -0,0 +1,8 @@ | |||
| export class Player { | |||
Co-authored-by: Shu <101587342+shugewang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.