Code review exercise: Kevin Thompson #119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smpezert
reviewed
Jan 9, 2024
| @@ -144,38 +92,84 @@ function wasCorrectlyAnswered() { | |||
| if ($this->currentPlayer == count($this->players)) $this->currentPlayer = 0; | |||
There was a problem hiding this comment.
Was it possible to avoid this magic number and add it somewhere else?
| . " now has " | ||
| .$this->purses[$this->currentPlayer] | ||
| . " Gold Coins."); | ||
| $this->getAnswerOutcome('correct'); |
There was a problem hiding this comment.
You could probably extract this and add it to a variable on the top called "correct" or "correctAnswer".
| $this->inPenaltyBox[$this->currentPlayer] = true; | ||
| function wasNotCorrectlyAnswered() | ||
| { | ||
| $this->getAnswerOutcome('incorrect'); |
| function didPlayerWin() { | ||
| function didPlayerWin() | ||
| { | ||
| return !($this->purses[$this->currentPlayer] == 6); |
There was a problem hiding this comment.
I can see a magic number that you could probably extract it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.