Skip to content

Feature/pr acceptance criteria#98

Merged
MDA2AV merged 2 commits intomainfrom
feature/pr-acceptance-criteria
Feb 16, 2026
Merged

Feature/pr acceptance criteria#98
MDA2AV merged 2 commits intomainfrom
feature/pr-acceptance-criteria

Conversation

@MDA2AV
Copy link
Owner

@MDA2AV MDA2AV commented Feb 16, 2026

Changes made

.github/workflows/probe.yml — 4 edits:

  1. Baseline gate logic (lines 202-212): After processing results, checks COMP-BASELINE and COMP-POST-CL-BODY for
    Fail verdicts across all probed servers, emitting ::error:: annotations
  2. Baseline section in PR comment (lines 253-262): Adds a prominent pass/fail heading before the per-category tables
  3. sys.exit(1) (lines 295-296): At the very end of the Python script (after writing probe-comment.md), exits
    non-zero if baseline failed
  4. if: always() on Upload PR comment (line 313): Ensures the artifact is uploaded even when the baseline gate fails
    the step

.github/workflows/probe-comment.yml — 1 edit:

  • Trigger on failure (line 13): Changed conclusion == 'success' to conclusion != 'cancelled' so the comment is
    posted even when the probe workflow fails due to baseline gate

@MDA2AV MDA2AV linked an issue Feb 16, 2026 that may be closed by this pull request
@sonarqubecloud
Copy link

@MDA2AV MDA2AV merged commit f67e906 into main Feb 16, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add PR acceptance conditions for framework updates

1 participant