Skip to content

Add communication between Quiz Service#25

Open
MarvinFischer wants to merge 1 commit intomainfrom
quiz-gen
Open

Add communication between Quiz Service#25
MarvinFischer wants to merge 1 commit intomainfrom
quiz-gen

Conversation

@MarvinFischer
Copy link
Copy Markdown

Description of changes

See MEITREX/quiz_service#17

How has this been tested?

Please describe the test strategy you followed. If not tested, please explain why.

  • automated unit test
  • automated integration test
  • manual, exploratory test

In case of manual test, please document the test well including a set of user instructions and prerequisites. Each including an action, it's result, and where appropriate a screenshot.

Checklist before requesting a review

  • My code is easy to understand
  • My code follows the coding guidelines of this project
  • My code fulfills all acceptance criteria
  • The test coverage (line and branch) is reasonably high, especially on Service classes and other classes with complex logic
  • I have made corresponding changes to the documentation or
    the wiki/adr
  • I made no breaking changes in the database schema or if so, I will perform a database migration

Checklist for reviewer

  • The code is easy to understand
  • The code follows
    the coding guidelines of
    this project
  • The code is tested or if not, the reason is documented or discussed
  • The added and existing tests reasonably cover the code change
  • The code has no breaking changes in the database schema or if so, the assignee is aware of it and
    will perform a database migration

@MarvinFischer MarvinFischer changed the title add event listener to quiz service and allow to init item with custom… Add communication between Quiz Service Sep 8, 2025
@MarvinFischer MarvinFischer marked this pull request as ready for review September 8, 2025 11:12
Copy link
Copy Markdown
Contributor

@ZiyaSelim ZiyaSelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants