Skip to content

Improve flexibility and robustness of Acoustics Module #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jmcvey3 wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Improve flexibility and robustness of Acoustics Module #433

jmcvey3 wants to merge 5 commits into from

Conversation

@jmcvey3
Copy link
Contributor

@jmcvey3 jmcvey3 commented Jan 21, 2026

There are three main changes in this pull request:

  1. Added the option to determine the number of datapoints in each FFT when creating the sound pressure PSDs. This was currently hardcoded to the maximum FFT length, i.e. the total number of datapoints in each window, which might be more resolution and require more storage space than desired
  2. Changed names of bin and windowing related attributes on the PSDs to make them easier to understand
  3. Gain was improperly added - the sign has been corrected

Minor changes are refactoring some of the argument type checks to clean them up.

@jmcvey3
Copy link
Contributor Author

jmcvey3 commented Jan 21, 2026

Looks like some remaining dependency issues related to timestamps

@jmcvey3 jmcvey3 added enhancement New feature or request Clean Up Improve code consistency and readability acoustics Acoustics Module labels Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

acoustics Acoustics Module Clean Up Improve code consistency and readability enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jmcvey3