Skip to content

feat: initial server template#2

Open
quantum9Innovation wants to merge 28 commits intomainfrom
server
Open

feat: initial server template#2
quantum9Innovation wants to merge 28 commits intomainfrom
server

Conversation

@quantum9Innovation
Copy link
Copy Markdown
Collaborator

Setup Flask server for handling frontend/backend integration and specify dependencies for reproducible builds

@quantum9Innovation quantum9Innovation added the enhancement New feature or request label Apr 18, 2025
@quantum9Innovation quantum9Innovation added this to the Final Showcase milestone Apr 18, 2025
@quantum9Innovation quantum9Innovation self-assigned this Apr 18, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR sets up a Flask server to handle frontend/backend integration while also specifying dependencies for reproducible builds.

  • Reorders and updates module imports in slicer.py
  • Introduces a test function and execution guard in slicer.py
  • Adds a basic Flask server with test endpoint in app.py

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.

File Description
slicer.py Reordered imports, added test function, and adjusted plot calls
app.py Introduces a basic Flask app with endpoints for testing
README.md Updates usage instructions and build checks
Files not reviewed (3)
  • .envrc: Language not supported
  • .gitlint: Language not supported
  • flake.nix: Language not supported

quantum9Innovation and others added 2 commits April 18, 2025 17:20
would have previously prevented slicer program from running

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@quantum9Innovation quantum9Innovation changed the title build: initial dependency spec feat: initial server template Apr 18, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request lays the foundation for a Flask server to facilitate frontend/backend integration and specifies dependencies to support reproducible builds. The changes include reordering and adjustments of import statements in slicer.py, the addition of a test function within slicer.py, and the creation of a basic Flask application with a new /test endpoint in app.py, along with updated run instructions in README.md.

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.

File Description
slicer.py Reorganized import order and added a test function for server testing
app.py Introduced Flask app with root and /test endpoints
README.md Updated the instructions for running the application and executing tests
Files not reviewed (3)
  • .envrc: Language not supported
  • .gitlint: Language not supported
  • flake.nix: Language not supported
Comments suppressed due to low confidence (1)

app.py:14

  • [nitpick] Function name 'callTest' does not follow Python's PEP8 naming conventions. Consider renaming it to 'call_test'.
def callTest():

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces an initial server template that sets up a Flask server for frontend/backend integration along with dependency and caching mechanisms for reproducible builds.

  • Implements a new slicing module (slicer.py) including image generation, caching, and cross-sectional mesh slicing functions.
  • Adds endpoints to the Flask app for testing, cleaning the cache, and retrieving slice images.
  • Adjusts Graphiti communication scripts and linter settings for code consistency.

Reviewed Changes

Copilot reviewed 13 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
slicer.py New mesh slicing, caching, and image generation functionality.
ruff.toml Linter configuration added to ignore selected lint errors.
graphiti_communication/readme.md Removed file; likely cleanup.
graphiti_communication/main.py Updated serial communication handling with refined variable names.
graphiti_communication/graphiticommands.py Refactored hex command generation with consistent formatting.
app.py New Flask routes added for server operations and slice retrieval.
README.md Updated instructions on running and checking the project.
Files not reviewed (4)
  • .envrc: Language not supported
  • .gitlint: Language not supported
  • flake.nix: Language not supported
  • pyrightconfig.json: Language not supported
Comments suppressed due to low confidence (1)

slicer.py:283

  • The parameter name 'dir' shadows the built-in function. Consider renaming it to 'direction' for clarity.
def generate(file: str, pose: np.ndarray, dir: np.ndarray, n: int):

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR sets up an initial Flask server template to handle frontend/backend integration while adding basic mesh slicing, caching, and serial communication functionality. Key changes include:

  • Introduction of new slicing, caching, and mesh processing functions in slicer.py
  • Updates to the serial communication logic in graphiti_communication modules
  • New Flask endpoints in app.py to trigger tests, cache cleaning, and slice retrieval

Reviewed Changes

Copilot reviewed 13 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
slicer.py Added mesh slicing, caching, and helper lambda functions
ruff.toml Configured linting ignores
graphiti_communication/readme.md Removed redundant readme file
graphiti_communication/main.py Renamed serial variable and adjusted message encoding
graphiti_communication/graphiticommands.py Updated hex command formatting using consistent f-string quotes
app.py Added Flask endpoints for testing, cache cleaning, and slice retrieval
README.md Updated run instructions and testing guidelines
Files not reviewed (4)
  • .envrc: Language not supported
  • .gitlint: Language not supported
  • flake.nix: Language not supported
  • pyrightconfig.json: Language not supported
Comments suppressed due to low confidence (1)

slicer.py:274

  • [nitpick] The variable name 'slice' shadows the built-in slice type. Consider renaming it to something like 'img' or 'slc' to avoid confusion.
for i, slice in enumerate(slices):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants