Created mouse_inputs.py#4
Open
quantum9Innovation wants to merge 1 commit intoMIT-Assistive-Technology:serverfrom
Open
Created mouse_inputs.py#4quantum9Innovation wants to merge 1 commit intoMIT-Assistive-Technology:serverfrom
quantum9Innovation wants to merge 1 commit intoMIT-Assistive-Technology:serverfrom
Conversation
So far, tracks motion on SpaceMouse - currently accounting for all x, y, z directional motion (including rotations, and "yaw", "pitch", and "roll" motions, which is a cool 3D rotation axis). Very basic at the moment
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new module, mouse_inputs.py, that tracks motion from a SpaceMouse device by interpreting x, y, z translations along with pitch, yaw, and roll rotations.
- Added functionality to read and interpret 13-byte data packets from the SpaceMouse input device.
- Implements basic console output for movement and rotation direction tracking.
Comments suppressed due to low confidence (1)
mouse_inputs.py:23
- Typo detected: 'reciever' should be corrected to 'receiver'.
Caveat: Spacemouse must be plugged in via USB - data is "hidden" via bluetooth AND the reciever unfortunately
| bluetooth AND the reciever unfortunately | ||
| """ | ||
|
|
||
| if len(data) < 7: |
There was a problem hiding this comment.
The data length check is insufficient: the function expects 13-byte data but only verifies a minimum of 7 bytes, which may lead to index errors.
Suggested change
| if len(data) < 7: | |
| if len(data) < 13: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, tracks motion on SpaceMouse - currently accounting for all x, y, z directional motion (including rotations, and "yaw", "pitch", and "roll" motions, which is a cool 3D rotation axis). Very basic at the moment