This repository was archived by the owner on May 20, 2025. It is now read-only.

Port to Python 3#6

Open

comrumino wants to merge 23 commits into

MITRECND:masterfrom

comrumino:master

Commits on Sep 4, 2019

Commits on Sep 22, 2019

Added .clang-format to make style in nidsmodule.c consistent
comrumino
committed
Ran clang-format and cleaned up docstrings
comrumino
committed
Fix incorrect sed change due to docstring macro and change in multiline char array style
comrumino
committed
Cleanup macros for long/int unification in the C-API for python 3
comrumino
committed
Removed some unused macros copied when trying to get a working compile point
comrumino
committed
Replaced PyString_FromStringAndSize with PyBytes_FromStringAndSize. As packet headers are binary, bytes is likely the desired type per https://docs.python.org/3/howto/cporting.html#str-unicode-unif…
comrumino
committed
Remove absurd redefinition of Bytes to Unicode that was copied of GitHub somewhere...
comrumino
committed
Remove more nonsensical define macros: PyString_FromFormat and PyString_FromFormatV
comrumino
committed
Removed macro for PyString_Check since PyErr_SetString requires that addr is a string within _parse_chksum_tuple
comrumino
committed
Remove last remaing conversion macros and cleaned seemingly ineffectual PyString_AS_STRING use... I miss unit tests
comrumino
committed
Change line length limit from 80 to 120 since I do not have IBM punch cards and too short of line lengths negatively impact reading speed---justification of personal preference.
comrumino
committed
Ran clang-format after change of 80 to 120 char per line
comrumino
committed
Removed comment block on resources for C-API and C porting after book marking... the official docs are not too hard to find
comrumino
committed
Changed indent width to 4 in clang-format
comrumino
committed
Ran clang-format with new indent width of 4
comrumino
committed
Made pynids_chksum_ctl__doc__ consistent with changes to other doc strings
comrumino
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port to Python 3#6

Port to Python 3#6
comrumino wants to merge 23 commits into
MITRECND:masterfrom
comrumino:master

Commits on Sep 4, 2019

First pass on porting nidsmodule to python 3

Ported Example from 2 to 3

Commits on Sep 22, 2019

Added .clang-format to make style in nidsmodule.c consistent

Ran clang-format and cleaned up docstrings

Fix incorrect sed change due to docstring macro and change in multiline char array style

Cleanup macros for long/int unification in the C-API for python 3

Removed some unused macros copied when trying to get a working compile point

Replaced PyString_FromStringAndSize with PyBytes_FromStringAndSize. As packet headers are binary, bytes is likely the desired type per https://docs.python.org/3/howto/cporting.html#str-unicode-unif…

Remove absurd redefinition of Bytes to Unicode that was copied of GitHub somewhere...

Remove more nonsensical define macros: PyString_FromFormat and PyString_FromFormatV

Removed macro for PyString_Check since PyErr_SetString requires that addr is a string within _parse_chksum_tuple

Remove last remaing conversion macros and cleaned seemingly ineffectual PyString_AS_STRING use... I miss unit tests

Change line length limit from 80 to 120 since I do not have IBM punch cards and too short of line lengths negatively impact reading speed---justification of personal preference.

Ran clang-format after change of 80 to 120 char per line

Removed comment block on resources for C-API and C porting after book marking... the official docs are not too hard to find

Changed indent width to 4 in clang-format

Ran clang-format with new indent width of 4

Made pynids_chksum_ctldoc consistent with changes to other doc strings

Commits on Sep 23, 2019

Cleaned up PyTypeObject structs and fixed type warnings

Fixed warning about u_char for urgdata

Replaced missed PyString_*

Commits on Sep 25, 2019

Fixed addr type check in _parse_chksum_tuple

Changed nidsmodule to nids in setup.py to fix import