Skip to content

Comments

Add setpoint scheduling#51

Draft
rosecodym wants to merge 1 commit intomasterfrom
revert-50-revert-46-feature/setpoint_schedules
Draft

Add setpoint scheduling#51
rosecodym wants to merge 1 commit intomasterfrom
revert-50-revert-46-feature/setpoint_schedules

Conversation

@rosecodym
Copy link
Contributor

This is a re-implementation of #46. It needs a backwards compatibility story.

@rosecodym
Copy link
Contributor Author

@samuelduchesne feel free to take this over and implement whatever backwards compatibility logic you want.

@samuelduchesne
Copy link
Member

Hi @rosecodym! I was taking a look a this. What do you mean by backwards compatibility logic?

@rosecodym
Copy link
Contributor Author

I just want to make sure that if someone loads an old library file and attempts to access these properties, nothing stupid or dangerous will happen. This version might do that, but I didn't get around to testing it.

@samuelduchesne
Copy link
Member

I see! I'll make a few tests and report back. One thing I did encounter is that for fields with a drop-down (schedules for example), UMI is not happy when the library is loaded if the drop-down is empty. Is there a way of allowing empty fields?

@rosecodym
Copy link
Contributor Author

Sorry, I don't follow. UMI doesn't load drop-downs; it loads serialized library JSON files. What's in the file that's causing problems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants