fix: add error handling and logging to model generator scripts#16
Open
harz05 wants to merge 1 commit intoML4EP:gpu/alpakafrom
Open
fix: add error handling and logging to model generator scripts#16harz05 wants to merge 1 commit intoML4EP:gpu/alpakafrom
harz05 wants to merge 1 commit intoML4EP:gpu/alpakafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15 (SOFIE equivalent of root-project/root#21190)
Changes
All 6 model generator scripts in
src/SOFIE_core/test/had no error handling. This adds:try/exceptaroundtorch.onnx.export()calls so failures are caught and logged.onnxfile exists and is non-empty after exportsys.exit(1)on failure so CI can detect itwith open()instead of bareopen()loggingfor progress and error messagesFiles changed:
LinearModelGenerator.pyConv1dModelGenerator.pyConv2dModelGenerator.pyConv3dModelGenerator.pyConvTrans2dModelGenerator.pyRecurrentModelGenerator.pyAll changes are consistent across the 6 files.