Skip to content

Comments

[MRG] 🎨 add cusor rules and fix some small issues#316

Merged
HuaizhengZhang merged 5 commits intomainfrom
hz/vllm
Jul 15, 2025
Merged

[MRG] 🎨 add cusor rules and fix some small issues#316
HuaizhengZhang merged 5 commits intomainfrom
hz/vllm

Conversation

@HuaizhengZhang
Copy link
Contributor

@HuaizhengZhang HuaizhengZhang commented Jul 14, 2025

Closes #313

  • add cursor project rules

Before submitting this PR, please make sure you have:

  • confirmed all checks still pass OR confirm CI build passes.
  • verified that any code or assets from external sources are properly credited in comments and/or in
    the credit file.

@HuaizhengZhang HuaizhengZhang self-assigned this Jul 14, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jul 14, 2025
@HuaizhengZhang HuaizhengZhang changed the title [WIP] 🎨 refactor vllm engine support [MRG] 🎨 add cusor rules and fix some small issues Jul 15, 2025
@HuaizhengZhang
Copy link
Contributor Author

@syangx38 I have fixed the issue. No worry at all

@HuaizhengZhang
Copy link
Contributor Author

@YuanmingLeee no need to consider anything related to windows.

lets make our doc and code small and clean

@YuanmingLeee
Copy link
Contributor

@YuanmingLeee no need to consider anything related to windows.

lets make our doc and code small and clean

OK, since I dev on Windows, so note down the process

Copy link
Contributor

@YuanmingLeee YuanmingLeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuaizhengZhang HuaizhengZhang merged commit 292d7fb into main Jul 15, 2025
3 checks passed
Copy link
Member

@huangyz0918 huangyz0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HuaizhengZhang In order to keep the mle-agent lite, we don't add any LLM model related dependencies into our lib's requirements.txt

"google-api-python-client~=2.143.0",
"google-auth-httplib2~=0.2.0",
"google-auth-oauthlib~=1.2.1",
"google-genai~=1.25.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the LLM related dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running mle new got google-genai dependency error

3 participants