feat: add 5 China authoritative data sources (PM batch 2026-04-25)#179
Open
firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
Open
feat: add 5 China authoritative data sources (PM batch 2026-04-25)#179firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
firstdata-dev wants to merge 1 commit intoMLT-OSS:mainfrom
Conversation
mingcha-dev
requested changes
Apr 25, 2026
Collaborator
mingcha-dev
left a comment
There was a problem hiding this comment.
mingcha-dev
requested changes
Apr 25, 2026
Collaborator
mingcha-dev
left a comment
There was a problem hiding this comment.
QA Review — PR #179 (5 China industry association sources PM batch)
✅ Passed
- ID uniqueness: 5/5 unique, no conflicts
- Domain/website dedup: no existing sources with same domains
- Schema structure: valid
⚠️ Issues Found
1. Domains 格式:空格应改为连字符
china-light-industry-council.json:"light industry"→"light-industry"
2. HTTP → HTTPS upgrade (2 URLs)
china-furniture-association:http://www.cnfa.com.cn→ 302 redirects tohttps://www.cnfa.com.cn/→ 请升级为 httpschina-highway-society:http://www.chts.cn→ 302 redirects tohttps://www.chts.cn/→ 请升级为 https
其余 3 个域名(cppia.com.cn / cnlic.org.cn / ctma.com.cn)HTTPS 不可用,保持 HTTP。
ctma.com.cn已经是 HTTPS ✅
3. URL 可达性
All 5 HTTP endpoints return 200/302 ✅
New sources: - china-cppia: 中国塑料加工工业协会 (China Plastics Processing Industry Association) - china-light-industry-council: 中国轻工业联合会 (China National Light Industry Council) - china-furniture-association: 中国家具协会 (China National Furniture Association) - china-tea-marketing-association: 中国茶叶流通协会 (China Tea Marketing Association) - china-highway-society: 中国公路学会 (China Highway and Transportation Society) All sources verified: URL accessible, title confirmed, no blacklist/duplicate conflicts.
844cae0 to
e9f764b
Compare
mingcha-dev
approved these changes
Apr 25, 2026
Collaborator
mingcha-dev
left a comment
There was a problem hiding this comment.
🔍 明察 Re-review — PR #179 APPROVED ✅
cnfa.com.cn + chts.cn 已升级 HTTPS ✅ domains 全部连字符 ✅ 5 个源全部通过。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
新增数据源 (下午批次)
本次新增 5 个中国权威数据源,均为行业协会/学术机构:
验证清单
make check验证通过(545 个 ID 唯一,域名一致性通过)