chore: migrate toolchain to Vite+ and pnpm#20
Merged
Conversation
- Replace Yarn Berry with pnpm (packageManager, lockfile, CI) - Replace microbundle with vp pack (tsdown) for library builds - Replace ESLint/Prettier with vp check (Oxlint/Oxfmt) - Replace standalone Vitest with vp test - Replace Husky/lint-staged with vp config/vp staged - Update CI to use voidzero-dev/setup-vp@v1 - Update package.json exports for tsdown output (.mjs/.cjs/.d.mts/.d.cts) - Update .nvmrc to Node 24 - Fix test imports: from '..' → from '../index' (Vite resolves bare parent to dist/ not source, breaking axios mock adapter) - Fix mock reset: resetHandlers() instead of reset() to preserve mock adapter across test lifecycle Consolidates 6 separate tools (Vite, Vitest, ESLint, Prettier, Husky, microbundle) into a single Vite+ toolchain.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (138)
📝 WalkthroughWalkthroughMigration from Yarn/ESLint/Prettier/Husky toolchain to pnpm/vite-plus, updating OpenAPI spec version from 1.8.3 to 1.8.7, adding POS auth token API endpoints, and standardizing code formatting to double-quotes with trailing commas. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant SDK as MONEI SDK
participant AuthAPI as POS Auth Token API
participant Config as Configuration
Client->>SDK: Initialize with account ID
SDK->>Config: Set headers (API key, Account ID)
Client->>SDK: Request POS auth token
SDK->>AuthAPI: POST /pos/auth-token<br/>(createPosAuthTokenRequest)
AuthAPI->>AuthAPI: Validate request<br/>(pointOfSaleId, storeId)
AuthAPI->>AuthAPI: Generate RS256 JWT<br/>(24-hour validity)
AuthAPI-->>SDK: Return 200 response<br/>(token: string)
SDK-->>Client: Return PosAuthTokenCreate200Response
Estimated Code Review Effort🎯 4 (Complex) | ⏱️ ~45 minutes ✨ Finishing Touches✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation
vp pack(tsdown) — outputs ESM (.mjs), CJS (.cjs), DTS (.d.mts/.d.cts)vp check(Oxlint + Oxfmt)vp test(vite-plus/test)vp config+vp stagedvoidzero-dev/setup-vp@v1importHelpers(tsdown bundles helpers), addedskipLibCheck(vite-plus types need TS 5), removedtsconfig.build.jsonfrom '..'→from '../index'(Vite resolves bare parent import to dist/ not source, breaking mock adapter);resetHandlers()instead ofreset()Test plan
pnpm typecheckpassesvp check— 0 errorsvp test— 53/53 tests passvp pack— ESM + CJS + DTS build succeedspnpm build— full pipeline (generate → replace → format → compile)Summary by CodeRabbit
New Features
Chores
Documentation