Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for skipping the resource quota deployment by introducing a new boolean flag. The changes incorporate the new flag in the deployment data structure, update the repository rules YAML configuration, and propagate the flag into the deployment environment generation.
- Added a new field "SkipQuotaDeploy" to relevant structures.
- Updated the generation of Kubernetes environment files to conditionally skip quota deployment.
- Mapped the new field appropriately in the deployment environment.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/infra/structure.go | Added the "SkipQuotaDeploy" field and updated quota template rendering logic. |
| src/entities/reporules.go | Introduced the YAML field "skip-quota-deploy" in repository rules. |
| src/entities/deployenv.go | Mapped the new flag from GitOps rules to the deployment data. |
Comments suppressed due to low confidence (2)
src/infra/structure.go:132
- Please ensure that tests verify that the quota template is not processed when 'SkipQuotaDeploy' is set to true.
+ if !d.SkipQuotaDeploy {
src/entities/deployenv.go:149
- [nitpick] Verify that this data mapping for 'SkipQuotaDeploy' aligns with expected behavior, particularly if 'ResourcesQuotas' might be nil in any scenarios.
+ SkipQuotaDeploy: d.Repository.GitOpsRules.SkipQuotaDeploy,
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
- Coverage 25.81% 25.74% -0.08%
==========================================
Files 18 18
Lines 1069 1080 +11
==========================================
+ Hits 276 278 +2
- Misses 781 790 +9
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.