Skip to content

Openmp bug fixes #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MicroTed wants to merge 2 commits into
base: develop
Choose a base branch
from
+4 −3
Open

Openmp bug fixes #1416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9d1762
mpas_atmphys_driver.F : Turn off OpenMP threading for driver_lsm_no…
MicroTed Apr 20, 2026
3250603
mpas_atm_time_integration.F : Add OMP barriers to prevent race cond…
MicroTed Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/core_atmosphere/dynamics/mpas_atm_time_integration.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1974,6 +1974,7 @@ subroutine atm_rk_integration_setup( state, diag, nVertLevels, num_scalars, &
theta_m_2(:,cellEnd+1) = 0.0_RKIND
!$acc end kernels

!$OMP BARRIER
!$acc parallel default(present)
!$acc loop gang worker
do iEdge = edgeStart,edgeEnd
Expand Down Expand Up @@ -2015,6 +2016,7 @@ subroutine atm_rk_integration_setup( state, diag, nVertLevels, num_scalars, &
end do
end do
!$acc end parallel
!$OMP BARRIER

MPAS_ACC_TIMER_START('atm_rk_integration_setup [ACC_data_xfer]')
!$acc exit data copyout(ru_save, rw_save, rtheta_p_save, rho_p_save, u_2, &
Expand Down
5 changes: 2 additions & 3 deletions src/core_atmosphere/physics/mpas_atmphys_driver.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,11 +292,10 @@ subroutine physics_driver(domain,itimestep,xtime_s)
call deallocate_lsm

elseif(config_lsm_scheme == 'sf_noahmp') then
do thread=1,nThreads
! Do not use Openmp here: the routine accepts thread loop bounds but does not use them
call driver_lsm_noahmp(block%configs,mesh,state,time_lev,diag,diag_physics, &
diag_physics_noahmp,output_noahmp,sfc_input,itimestep, &
cellSolveThreadStart(thread),cellSolveThreadEnd(thread))
enddo
cellSolveThreadStart(1),cellSolveThreadEnd(nThreads))
endif

call allocate_seaice(block%configs)
Expand Down