fix(ncert): format DTO contracts and align response types#412
Open
Tuba1809 wants to merge 4 commits into
Open
Conversation
|
@Tuba1809 is attempting to deploy a commit to the Adarsh's projects Team on Vercel. A member of the Team first needs to authorize it. |
MRIARC-08
requested changes
Jun 25, 2026
MRIARC-08
left a comment
Owner
There was a problem hiding this comment.
@Tuba1809 This is close and it merges cleanly with current main. TypeScript passes locally, but focused ESLint still fails on Prettier formatting in src/modules/ncert/ncert.types.ts.
Local checks:
pnpm exec tsc --noEmitpasses.pnpm exec eslint src/modules/ncert/ncert.types.tsfails with 8 Prettier errors.
Please run the repo formatter on that touched file and push the formatting result. No logic rewrite needed from what I checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #59
This PR completes the NCERT DTO contract work by applying the remaining formatting fixes and ensuring the response contracts accurately reflect the current controller and service behavior.
Changes
DTO Alignment
levelacademicClassIdtitle,order,contentFormat, andcontentSourcetitleandorderResponse Contracts
Added
ClassesResponseDTOto match the classes endpoint response shape:{ classes: AcademicClassDTO[] }Updated
ChaptersResponseDTOto match the livegetChaptersendpoint response:ApiResponseDTO<SubjectDTO>Preserved existing controller-aligned response contracts for subjects, chapters, and topics
Formatting
ncert.types.tsBenefits
Testing
Notes
This PR addresses the final review feedback from the previous NCERT DTO contract work by ensuring response types match the actual controller responses and by applying the requested formatting fixes.