fix(#244): pass classId when loading quiz creation subjects#421
Open
0xPyxis wants to merge 1 commit into
Open
Conversation
|
@0xPyxis is attempting to deploy a commit to the Adarsh's projects Team on Vercel. A member of the Team first needs to authorize it. |
MRIARC-08
requested changes
Jun 25, 2026
MRIARC-08
left a comment
MRIARC-08
left a comment
Owner
There was a problem hiding this comment.
@0xPyxis The actual bug fix is correctly scoped: fetchSubjects now receives the class id and calls /api/ncert/subjects?classId=....
Local checks:
pnpm exec tsc --noEmitpasses.pnpm testpasses: 8 files / 35 tests.pnpm exec eslint src/components/QuizCreationForm.tsx src/lib/quiz.tsfails with 5 Prettier formatting errors.
Please run the repo formatter on the touched files and push the result. Since this touches the quiz creation form UI, it will also need a manual visual/flow review before merge.
MRIARC-08
added
gssoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #244
The quiz creation flow was fetching subjects without providing the user's classId, causing subjects to fail loading correctly.
CHANGES
fetchSubjectsinsrc/lib/quiz.tsto accept aclassIdclassIdquery parameter to the/api/ncert/subjectsrequestQuizCreationFormto pass the user's class when fetching subjectsRESULT
Subjects are now loaded correctly based on the user's class during quiz creation.